Add share modal #674
Closed
Add share modal #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yash Sharma <[email protected]>
|
Share modal is also will push it quickly after testing |
Signed-off-by: Yash Sharma <[email protected]>
Signed-off-by: Yash Sharma <[email protected]>
Signed-off-by: Yash Sharma <[email protected]>
Signed-off-by: Yash Sharma <[email protected]>
Signed-off-by: Yash Sharma <[email protected]>
Signed-off-by: Yash Sharma <[email protected]>
Signed-off-by: Yash Sharma <[email protected]>
Signed-off-by: Yash Sharma <[email protected]>
Signed-off-by: Yash Sharma <[email protected]>
Signed-off-by: Yash Sharma <[email protected]>
Signed-off-by: Yash Sharma <[email protected]>
|
Testing in cloud |
Signed-off-by: Yash Sharma <[email protected]>
Signed-off-by: Yash Sharma <[email protected]>
Yashsharma1911
commented
Jul 12, 2024
Signed-off-by: Yash Sharma <[email protected]>
Signed-off-by: Yash Sharma <[email protected]>
sudhanshutech
requested changes
Jul 12, 2024
| '&:after': { | ||
| display: 'none' | ||
| }, | ||
| fontFamily: 'Qanelas Soft, sans-serif', |
| <PublicIcon | ||
| width={24} | ||
| height={24} | ||
| stroke={theme.palette.mode === 'dark' ? WHITE : BLACK} |
There was a problem hiding this comment.
don't use direct colors, use tokens here.
|
Checking in again. No new commits. Is @sudhanshutech feedback to be incorporated, @Yashsharma1911? |
|
Yes and I hold off on this as this is a feature and we got bugs in the catalog in GitHub action, so I prioritized them I already mentioned in cloud PR I'll be merging them by end of this week |
1 task
|
@Yashsharma1911 circling back... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes #
This PR adds two reusable components
Signed commits